It's all perspective.
Most of us here are either in or past our mil experience, and it's always easy to poke holes after you've seen behind the curtain and understand all the mis-steps and mistakes that you did see until you were inside. In the end though, I think recruiting for the military will always be difficult. It should be. "If it were easy, everyone would do it" and we don't want everyone. In the same right, the US military has routinely produced men and women with strong character and solid teamwork skills. It has to do with volunteering to do for other what they won't or can't do for themselves. That take nobility. It always will.
What is concerning is this line, which is ABSOLUTELY true.
The quality of the members of the military will continue to be of noble character simply because it requires volunteering. The effectiveness of the force, however, can only get betrayed by it's political leaders...as happened in AFG and is still happening with the social woke experimentation bullshit.
If someone is joining solely for the benefits, yeah, they're gunna be sorely disappointed that it's not as benefit rich as working for Apple, Google, or Starbucks. Frankly, it shouldn't be. Baristas and coders are in the business of service and providing a product for the prime purpose of getting paid to do so. Soldiers, sailors and airmen are in the business of visiting death and destruction on our nation's enemies. Hardly a comparison there.
As to who someone becomes after serving even one four year stint, the results are undeniable. Sure, not all job skills transfer. But self confidence, decision making skills, and the ability to work in a team always do.
At the heart of all this is that people need significance in their professional lives for them to care about what they do and who they are becoming. I've definitely seen that need in people I work with in my civilian job. Men and women want to know their work has made a difference. Military operators rarely come out the other end of their service with that problem.
What we do matters and THAT is what will ultimately keep younger generation continuing to volunteer. There will always be bad leaders, politicians messing things up, and GO's that are completely worthless. That's what makes the good leaders stand out so much. The work will continue to be awesome and unique in ways that you simply can't get outside the military.
I've been completely honest with my kids. They're not at decision time yet, but my 14 year old son has already expressed interest in the cool things about the military, and even expressed that he'd love to fly the A-10. I'm all about it, but I refuse to push him either way. The best any of us can do is be honest and transparent. The job will sell itself to those who we need. It always has, and always will. Hopefully, our political leaders will unass themselves, continue to fight for benefit improvement, and work for their people, instead of expecting their people to work for them.